Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement for loading worlds #110

Open
jtJava opened this issue May 23, 2024 · 5 comments
Open

Performance improvement for loading worlds #110

jtJava opened this issue May 23, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@jtJava
Copy link

jtJava commented May 23, 2024

Is your feature request related to a problem? Please describe.
When loading worlds, a Spigot/Paper world config is generated, causing worlds to take 30ms+ to load

image

Describe the solution you'd like
Some sort of config value or startup parameter that avoids the config generation

@jtJava jtJava added the enhancement New feature or request label May 23, 2024
@kyngs
Copy link
Member

kyngs commented May 23, 2024

Send the full spark report.

@jtJava
Copy link
Author

jtJava commented May 24, 2024

Send the full spark report.

This is with 200 worlds being cloned, first few clones take 30-50ish ms, then drop down to around 10 ms each
https://spark.lucko.me/V2bJZvFVSB

@davidmayr
Copy link

I have noticed this as well. The Spigot Config part is easy to fix, but the paper config seems quite difficult (at least for me)

@jtJava
Copy link
Author

jtJava commented May 25, 2024

This should be able to be fixed by just grabbing a spigot and paper config from an already existing world if possible. If it's a clone, maybe in the template world the config can be saved for future clones. I did a lazy fix in my own fork and was able to drop world load times to 1-2 ms each

@davidmayr
Copy link

This should be able to be fixed by just grabbing a spigot and paper config from an already existing world if possible. If it's a clone, maybe in the template world the config can be saved for future clones. I did a lazy fix in my own fork and was able to drop world load times to 1-2 ms each

Caching the config is indeed a possible solution I didn't think of. I don't like using one from another world tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants