Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate sync client #101

Closed
nhannamsiu opened this issue Apr 15, 2022 · 2 comments
Closed

Deprecate sync client #101

nhannamsiu opened this issue Apr 15, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@nhannamsiu
Copy link
Contributor

nhannamsiu commented Apr 15, 2022

Motive

Note: by the day this issue is filed, both clients have identical feature set.

With all the new features added lately to help reducing the chance to have sequence mismatch error, the logic flows in sync and async clients start to diverge. This will require more time and effort down the road to keep both clients, their examples and API doc up-to-date.

Given that sync client is a subset and way slower than async client, Injective MM & API users rarely apply it in their applications. I assume this deprecation would not introduce much trouble to the users while allowing us to focus on polishing async client and its examples, API documentation.

What do you guys think?

@nhannamsiu nhannamsiu added enhancement New feature or request question Further information is requested labels Apr 15, 2022
@achilleas-kal
Copy link
Collaborator

I fully agree, we can use the time we'd devote to the sync client to support the new SDKs in GO/Typescript and improve them.

Market makers and API traders should use the async client since it's much faster and given how the nature of trading requires one to invoke multiple methods at a given time the async client is naturally the ideal choice since they can run concurrent coroutines.

Let's keep the sync client for the near-term (6-month period) but put a notice that it will no longer be supported - this should give ample time for anyone who might be using it to change to the async client.

@DrunkenRandomWalker
Copy link
Contributor

DrunkenRandomWalker commented Apr 15, 2022

Agreed. I suggest we keep sync client in the repo for another one month, cause some people might still using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants