Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal line/Spacer renders before image #305

Open
kokoISnoTarget opened this issue Apr 7, 2024 · 1 comment · May be fixed by #318
Open

Horizontal line/Spacer renders before image #305

kokoISnoTarget opened this issue Apr 7, 2024 · 1 comment · May be fixed by #318
Labels
A-image Area: Image decoding/rendering/etc. A-interpreter Area: Changes impacting the HTML interpreter C-bug Category: Something isn't working

Comments

@kokoISnoTarget
Copy link
Contributor

kokoISnoTarget commented Apr 7, 2024 •
edited
Loading 

![](https://placehold.co/200x100/EEE/31343C)

<hr>

Renders in Inlyne (4.2):
Screenshot_2024-04-07-11-33-02_5120x1263

GitHub:

(edit): This does not occur when align center or right is used, so the problem lies somewhere in how we handle image rows because https://github.com/Inlyne-Project/inlyne/blob/32619fff5ab60e1217d12be43b91e679042eb0f2/src/interpreter/mod.rs#L341C9-L352C10
@CosmicHorrorDev CosmicHorrorDev added the C-bug Category: Something isn't working label Apr 8, 2024
@CosmicHorrorDev
Copy link
Collaborator

Yeah the code for handling inline images has been notoriously buggy. I'll work on adding some more tests on how that part of the code should behave over time since there are a lot of different variations that people use for their README's headers

@CosmicHorrorDev CosmicHorrorDev added A-image Area: Image decoding/rendering/etc. A-interpreter Area: Changes impacting the HTML interpreter labels Apr 14, 2024
@kokoISnoTarget kokoISnoTarget linked a pull request Jun 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-image Area: Image decoding/rendering/etc. A-interpreter Area: Changes impacting the HTML interpreter C-bug Category: Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add hir kokoISnoTarget/inlyne
2 participants
@CosmicHorrorDev @kokoISnoTarget