Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible rust 1.80 build issues #356

Closed
dezren39 opened this issue Aug 29, 2024 · 5 comments
Closed

possible rust 1.80 build issues #356

dezren39 opened this issue Aug 29, 2024 · 5 comments

Comments

@dezren39
Copy link

hello i am unable to build this pkg from nixpkgs master branch right now.

i believe it is due to NixOS/nixpkgs#332957

i attempted to confirm this myself, but had a couple issues working through building in general, with cargo wanting a 'wayland-client' to be available. this is likely just because i don't have my enviroment properly setup for building inlyne.

in other packages they suggest updating 'time' but i don't think that is the issue here.

@CosmicHorrorDev
Copy link
Collaborator

It's possible that there could be issues as the last release looks like it's on an affected time version

cargo tree -p time
time v0.3.29
├── deranged v0.3.8
├── itoa v1.0.9
└── time-core v0.1.2

which predates the PR to time fixing it (0.3.29 was released 7 months ago and the PR was merged 5 months ago), and I can confirm that I'm getting the expected error when trying to build the last inlyne release with a more recent toolchain

   Compiling enumflags2 v0.7.7
   Compiling gpu-descriptor v0.2.3
error[E0282]: type annotations needed for `Box<_>`
  --> /home/wintermute/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.29/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

   Compiling zvariant_derive v3.14.0
   Compiling darling v0.14.4

The main branch here is already updated to the latest time, although I won't be able to get a release out for likely a couple more weeks at least

As per the wayland-client issues that's an expected dep if the wayland feature is enabled which it is by default. There's are details on what dependencies are required in the Building from Souce section of the README

@CosmicHorrorDev
Copy link
Collaborator

Eh on second thought we already have a branch for 0.4, so I can push out a patch release with an updated time version later today

@CosmicHorrorDev
Copy link
Collaborator

A new release with an updated time version is now out which @r-ryantm will likely pick up and open a PR to nixpkgs soon to update to the latest version

@CosmicHorrorDev
Copy link
Collaborator

Went ahead and opened a PR to nixpkgs NixOS/nixpkgs#338369

@CosmicHorrorDev
Copy link
Collaborator

Closing this as it seems to be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants