-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Renaming "Patlet" to "Summary" #564
Comments
@yuhattor I am curious to get your opinion about this. How did you actually translate the word "Patlet" into Japanese? |
In terms of costs to implement this, I quickly checked, and outside of the patterns itself, we have not used the word all that much. Details:
So to implement this we would have to do two things:
|
Actually, I have not translated Patlet. The reason is that Title and Patlet are used in a script that generates summaries, and if you translate them into Japanese, the script will not work properly. I thought about changing the script, but it seemed a bit difficult at the time, so I decided not to do it and to use Title and Patlet as they are. I'm definitely in favor of changing PatLet to an easier to understand name like Summary, Description, Abstract, etc 😄 😄 😄 |
@yuhattor quick detour here related to this:
Did you have some ideas for how to implement this different already? Exploring some below: 1) Use the order of sectionsI think we could change the script to "pick the first section as Title, and the 2nd section as Patlet". 2) Use a front matter in gitbookA more stable alternative would be to add some type of jekyll-style front matter to all patter files, so that we can pick up the title + patlet from there, rather than having to parse it out of the markdown. I do remember testing some time back that at least some front matter variables can be used with gitbook, but I am not sure which ones. 3) other ideas? |
If I misunderstood your question, please let me know, but what I meant that was difficult was not from the technical mattter. At the time I made the first contribution to the book I was complete stranger, and at the time I thought Patlet had a special meaning. So I thought it was a bit difficult to change the name / or propose to change as a stranger. If you want to change the title, and also the implementation as well, you can just replace all the Patlet with with other words like "Description" or "Summary", and change the below scripts. InnerSourcePatterns/book/scripts/generate_toc.rb Lines 55 to 63 in 36e2ca8
|
@yuhattor yeah we had a bit of a misunderstanding here. What I meant was: I am leaning towards option (2) above, even though that would mean that title/description are stored in two places: the respective pattern section and the metadata. |
In our pattern template we have a section called Patlet. We define it as:
However many readers find this confusing, as Patlet is no real word in Englisch, and does not have an intuitive meaning. So while the word Patlet is kind of cute, and maybe fun for some of us (hardcore pattern nerds that is :)), it is not very helpful for the average consumer of our patterns.
Therefore I propose to replace the word Patlet by Summary instead.
Here is how I propose to change the definition in the pattern template.
The text was updated successfully, but these errors were encountered: