Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new images for Standard Base Documentation #463

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

spier
Copy link
Member

@spier spier commented Sep 30, 2022

Implements #462

@spier
Copy link
Member Author

spier commented Sep 30, 2022

I take this comment by @MaineC as confirmation that these images are good to be merged.

@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Sep 30, 2022
@spier
Copy link
Member Author

spier commented Sep 30, 2022

I have to keep the old image around, as the Japanese book is still using it.

Also when creating these new images I created a folder based on the filename of the pattern below assets, so that all visuals for a pattern are grouped together in that folder. Also allowed me to add a README with license info etc.

Not sure if this approach scales but trying it out.

@spier spier merged commit c6461be into main Sep 30, 2022
@spier spier deleted the new-visuals-base-documentation branch September 30, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant