Skip to content
This repository has been archived by the owner on Mar 20, 2021. It is now read-only.

Tabs or Spaces? #101

Open
dellagustin opened this issue Feb 23, 2020 · 4 comments
Open

Tabs or Spaces? #101

dellagustin opened this issue Feb 23, 2020 · 4 comments

Comments

@dellagustin
Copy link
Contributor

Currently there is a mixed usage of tabs and spaces on the webpage files.
It would be good to start defining the rules and document them in the contribution guidelines.

I personally prefer tabs, and support the arguments raised by Lea Verou in her article Why tabs are clearly superior.

@rrrutledge
Copy link
Collaborator

This is a great question, @dellagustin. Why don't you represent this topic in #tech-infra to get a discussion and some direction?

@dellagustin-sap
Copy link
Contributor

Linking back to the corresponding slack thread: https://innersourcecommons.slack.com/archives/CGSE508A1/p1582562709013200

@lenucksi
Copy link
Member

I'm fine with Tabs. Some consistency and linting would probably not harm anyone and might help others.

@marshmallowrobot
Copy link

The correct answer to tabs vs spaces is: the one that you enforce.

It really makes no difference which you choose. So long as everyone uses an editor that can support an .editorconfig file, we'll all have the same settings. As files get touched over time, this problem will solve itself. We could also use a linter to enforce our preference as a build step, so that PRs dont get merged that don't follow the spacing rules.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants