Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'spread mark' support #43

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add 'spread mark' support #43

wants to merge 4 commits into from

Conversation

TheBloodMan49
Copy link
Member

@TheBloodMan49 TheBloodMan49 commented Nov 22, 2024 •
edited by pixup1
Loading

Description

Allows to empty a mark and rebalance its devices on the others, uses mark priorities to spread

Checklist

  • I have tested the changes locally and they work as expected.
  • I have documented the changes in docs/manuel, if necessary.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

#41

@TheBloodMan49 TheBloodMan49 self-assigned this Nov 22, 2024
@TheBloodMan49
Copy link
Member Author

TODO : Test with the production stack and several real users to check correct functionnality

@TheBloodMan49 TheBloodMan49 added enhancement New feature or request Front frontend thing Back backend thing labels Nov 22, 2024
@pixup1
Copy link
Member

pixup1 commented Nov 22, 2024 •
edited
Loading

See discord

Issue #41 was created here also
Edit: edited

@TheBloodMan49 TheBloodMan49 linked an issue Nov 22, 2024 that may be closed by this pull request
Add a "Rebalance" button to marks #41
Open
pixup1
pixup1 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@pixup1 pixup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! :D

Ecnama
Ecnama approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@Ecnama Ecnama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ig

@TheBloodMan49
Copy link
Member Author

I still need to add tests for all that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ecnama Ecnama Ecnama approved these changes

@pixup1 pixup1 pixup1 approved these changes

@KwikKill KwikKill Awaiting requested review from KwikKill

Assignees

@TheBloodMan49 TheBloodMan49

Labels
Back backend thing enhancement New feature or request Front frontend thing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a "Rebalance" button to marks
3 participants
@TheBloodMan49 @pixup1 @Ecnama