Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new switch -v to obtain accelerator version #144

Open
grantkriegerai opened this issue Aug 5, 2024 · 7 comments
Open

Create a new switch -v to obtain accelerator version #144

grantkriegerai opened this issue Aug 5, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@grantkriegerai
Copy link
Contributor

Create a new switch -v to obtain accelerator version.This version number should align to the tag build number on github

@grantkriegerai grantkriegerai added the enhancement New feature or request label Aug 5, 2024
@jrampono jrampono added this to the V0.5.0 milestone Aug 8, 2024
@grantkriegerai grantkriegerai modified the milestones: V0.5.0, V0.6.0 Aug 9, 2024
@grantkriegerai grantkriegerai modified the milestones: V0.6.0, V0.7.0 Aug 15, 2024
@sbandarumelb
Copy link
Collaborator

@insightgrantkrieger to confirm an strategic approach to populate the latest version.

@grantkriegerai
Copy link
Contributor Author

@jrampono any ideas on how to get the installed github release shown in the application?.EG --V would return V0.6.0

@amitesh-insight
Copy link

@insightgrantkrieger, @sbandarumelb, Sorry didn't got time to work on this issue but here is my view.

We can add a command "version" instead of "--v". so, at top level there will be 2 command "version" and "run-all".

here is python code to get github version:
import requests
url = 'https://github.com/Insight-Services-APAC/APAC-Capability-DAI-DbtFabricSparkNb/releases/latest'
r = requests.get(url)
version = r.url.split('/')[-1]

print(version)

@grantkriegerai
Copy link
Contributor Author

I would prefer --V or --version to align to standard however if that is not possible I would fall back on that suggestion. @jrampono what do you think?
That Python code is great to find the latest version on github however the intention is to find the current installed version which may not equal the latest version on github.

@grantkriegerai
Copy link
Contributor Author

@sbandarumelb please follow up with @jrampono he has a solution to set extra properties in setup.py which we could embed the version in

@grantkriegerai grantkriegerai modified the milestones: V1.7.7, V1.7.8 Aug 22, 2024
@sbandarumelb
Copy link
Collaborator

@insight1grantkrieger encountering an issue where the dbt_wrapper function is not being recognized as a cmdlet. Despite attempting various solutions such as re-cloning, creating a new project/workspace/lakehouse, and initiating the project following the documentation instructions, the issue persists. @JacquesInsight is also experiencing a similar problem in his repository.
image

@sbandarumelb
Copy link
Collaborator

image
@insightgrantkrieger When utilizing the metadata library to retrieve the version, I am currently only able to obtain the version specified in the install_requires list, rather than the expected package_version "1.7.7". Especially when passing the package name. Is it possible to update the highlighted version information to align with the latest version.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants