New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when using 'check' strategy in snapshots #194

Open

jp-vanheerden opened this issue Nov 27, 2024 · 0 comments

Labels

bug

Contributor

jp-vanheerden commented Nov 27, 2024

Describe the bug
When using a snapshot strategy of 'check' with check_cols, the SQL generate contains malformed WHERE

To Reproduce
Steps to reproduce the behavior:

create a snapshot with strategy = 'check' and define some check_cols
build the project
review the generated SQL in the notebook

Expected behavior
notebook SQL should contain appropriate WHERE based on check_cols

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: Windows
Browser: Chrome
Version: Framework version 1.7.7

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

jp-vanheerden added the bug label

jp-vanheerden mentioned this issue

fix for issue194 'check' strategy #196

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment