Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for flexible model notebook Naming convention #25

Open
jp-vanheerden opened this issue Jun 19, 2024 · 2 comments
Open

Allow for flexible model notebook Naming convention #25

jp-vanheerden opened this issue Jun 19, 2024 · 2 comments

Comments

@jp-vanheerden
Copy link
Contributor

jp-vanheerden commented Jun 19, 2024

The project should allow for a flexible pattern based naming convention for generated notebooks. For the example below, where the project is Investment the transformation stage is raw_to_conformed and the model is asx_contituents, the generated notebook should be:

NB_raw_to_conformed_asx_contituents

image

@jp-vanheerden jp-vanheerden changed the title Change model notebook Naming convention Allow for flexiable model notebook Naming convention Jun 20, 2024
@grantkriegerai
Copy link
Contributor

Duplication of issue 26

@grantkriegerai grantkriegerai closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
@grantkriegerai grantkriegerai reopened this Jul 2, 2024
@jp-vanheerden jp-vanheerden changed the title Allow for flexiable model notebook Naming convention Allow for flexible model notebook Naming convention Jul 14, 2024
@JacquesInsight JacquesInsight self-assigned this Aug 6, 2024
@JacquesInsight
Copy link
Contributor

In discussion with @jp-vanheerden JP he mentioned that the 1st prize would be to have the ability to define a pattern but would settle for a "prefix" like "NB_"

Naming Example:
image

The script names are currently being read from "node_id" in the sql string passed to the Livysession.py script "LivyCursor" class.

Sample of sql:
image

From discussions with @insightgrantkrieger this is something that is controlled by "internal" code from the dbt adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants