Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for flexible master notebook naming convention #26

Open
jp-vanheerden opened this issue Jun 19, 2024 · 5 comments
Open

Allow for flexible master notebook naming convention #26

jp-vanheerden opened this issue Jun 19, 2024 · 5 comments

Comments

@jp-vanheerden
Copy link
Contributor

jp-vanheerden commented Jun 19, 2024

There should be a configurable naming convention for Master notebooks.

In a scenario where the project is called Investment and there is a naming convention that includes "NB_" as a prefix, the project notebooks could be:

NB_Investment_master_notebook
NB_Investment_master_notebook_0

image

@jrampono
Copy link
Collaborator

Hey @jp-vanheerden, I don't think that we should be including client specific requirements or changes directly in this repo. The approach should be

a) Can we make articulate the requirement in a way that makes it generic? In this case I would say "yes" and the requirement prob needs to change to add dbt project name or "domain" to the notebook naming conventions to allow multiple dbt_projects to co-exist in one workspace., or

b) If we can't make the requirement generic we may need to make a clone of the repo specifcally for the client and put client specific modifications in there.

@insightgrantkrieger what are your thoughts?

@jp-vanheerden
Copy link
Contributor Author

100% agree @jrampono - I was caught up with the excitement of getting this going for Perpetual. I'll change both issues to be a bit more generic

@jp-vanheerden jp-vanheerden changed the title Change master notebook naming convention Allow for flexible master notebook naming convention Jun 20, 2024
@grantkriegerai
Copy link
Contributor

Hi @jrampono I totally agree. This accelerator should be generic enough to be able to go into any new company. Any future requests that come through with company specific requirements we will address and make them generic

@grantkriegerai grantkriegerai self-assigned this Jul 5, 2024
@grantkriegerai grantkriegerai removed their assignment Aug 13, 2024
@grantkriegerai
Copy link
Contributor

Discuss and see if still required

1 similar comment
@grantkriegerai
Copy link
Contributor

Discuss and see if still required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants