feat: support dynamic emscripten module import in web workers #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
reviewed
Oct 12, 2023
thewtex
force-pushed
the
worker-dynamic-import
branch
from
8702bf0 to
b63b9f1
Compare
Firefox now has dynamic ESM support in web workers, and it is enabled in the current stable release. This means we can: 1. Allow WebPack, Vite, Rollup, to bundle the web workers as usual by default and they can use the dynamic import at runtime. 2. Not build the UMD Emscripten module wrapper for importScript imports This patch sets the bundler handling of pipeline.worker.js to be the default, and stops building the UMD wasm modules.
thewtex
force-pushed
the
worker-dynamic-import
branch
from
b63b9f1 to
9d5cd0d
Compare
|
🎉 This PR is included in version 1.0.0-b.148 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Oct 13, 2023
No longer necessary via InsightSoftwareConsortium#970
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Oct 13, 2023
creation Follow-up to InsightSoftwareConsortium#970 when using Vite with derived packages.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
# [1.0.0-b.149](itk-wasm-v1.0.0-b.148...itk-wasm-v1.0.0-b.149) (2023-10-13) ### Bug Fixes * **createWebWorkerPromise:** use type: 'module' option for Worker ([92f9492](92f9492)), closes [#970](#970)
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Oct 16, 2023
No longer necessary via InsightSoftwareConsortium#970 Improve image-io testing speed via https://dev.to/noriste/speed-up-e2e-tests-for-vite-based-apps-3k4l
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Oct 17, 2023
No longer necessary via InsightSoftwareConsortium#970 Improve image-io testing speed via: https://dev.to/noriste/speed-up-e2e-tests-for-vite-based-apps-3k4l Resolve library worker bundling per: https://medium.com/adevinta-tech-blog/introducing-web-workers-to-improve-subito-it-performance-part-2-92bcfed8a62 Vite does not support pre-bundling of web workers in dependencies, so we have to add packages to optimizeDeps.exclude. gkjohnson/three-gpu-pathtracer#355 (comment)
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Oct 20, 2023
No longer necessary via InsightSoftwareConsortium#970 Improve image-io testing speed via: https://dev.to/noriste/speed-up-e2e-tests-for-vite-based-apps-3k4l Resolve library worker bundling per: https://medium.com/adevinta-tech-blog/introducing-web-workers-to-improve-subito-it-performance-part-2-92bcfed8a62 Vite does not support pre-bundling of web workers in dependencies, so we have to add packages to optimizeDeps.exclude. gkjohnson/three-gpu-pathtracer#355 (comment) Some updates in compare-images. Further updates to packages in follow-up commits.
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Oct 30, 2023
No longer necessary via InsightSoftwareConsortium#970 Improve image-io testing speed via: https://dev.to/noriste/speed-up-e2e-tests-for-vite-based-apps-3k4l Resolve library worker bundling per: https://medium.com/adevinta-tech-blog/introducing-web-workers-to-improve-subito-it-performance-part-2-92bcfed8a62 Vite does not support pre-bundling of web workers in dependencies, so we have to add packages to optimizeDeps.exclude. gkjohnson/three-gpu-pathtracer#355 (comment) Some updates in compare-images. Further updates to packages in follow-up commits.
thewtex
added a commit
to thewtex/ITK-Wasm
that referenced
this pull request
Nov 5, 2023
Use the app's bundler's support for the worker by default. No longer necessary via InsightSoftwareConsortium#970 Improve image-io testing speed via: https://dev.to/noriste/speed-up-e2e-tests-for-vite-based-apps-3k4l Resolve library worker bundling per: https://medium.com/adevinta-tech-blog/introducing-web-workers-to-improve-subito-it-performance-part-2-92bcfed8a62 Vite does not support pre-bundling of web workers in dependencies, so we have to add packages to optimizeDeps.exclude. gkjohnson/three-gpu-pathtracer#355 (comment) Some updates in compare-images. Further updates to packages in follow-up commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox now has dynamic ESM support in web workers, and it is enabled in the current stable release.
This means we can:
This patch sets the bundler handling of pipeline.worker.js to be the default, and stops building the UMD wasm modules.