Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor issues in user_guides/debugging/local_variables.html #573

Open
mpuputti opened this issue Sep 28, 2021 · 2 comments · May be fixed by #1248
Open

Minor issues in user_guides/debugging/local_variables.html #573

mpuputti opened this issue Sep 28, 2021 · 2 comments · May be fixed by #1248
Assignees
@roxx30198
Labels
bug Something isn't working documentation Improvements or additions to documentation user User submitted issue
Milestone
0.18.1

Comments

@mpuputti
Copy link

At the end of the page https://intelpython.github.io/numba-dppy/latest/user_guides/debugging/local_variables.html, the script ends before the function review() is called:

@dppy.func
def revive(x):
    return x


@dppy.kernel(debug=True)
def data_parallel_sum(a, b, c):
    i = dppy.get_global_id(0)
    l1 = a[i] + 2.5
    l2 = b[i] * 0.3
    c[i] = l1 + l2
    revive(a)   <--- This line is missing

Below the above script, annotations seem to have mismatch with line numbers:

# --- LINE 24 ---    <--- This should refer the line 21 in the above script

@dppy.kernel(debug=True)

There is also another annotation example in this page, and that seems to have similar issue with line numbers mismatching with the associated script.
@PokhodenkoSA
Copy link
Contributor

Thank you @mpuputti.

@diptorupd diptorupd added the user User submitted issue label Oct 18, 2022
@diptorupd
Copy link
Contributor

@roxx30198 Can you please update the docs as suggested?

@roxx30198 roxx30198 linked a pull request Dec 15, 2023 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roxx30198 roxx30198

Labels
bug Something isn't working documentation Improvements or additions to documentation user User submitted issue
Projects
None yet
Milestone
0.18.1
Development

Successfully merging a pull request may close this issue.

WIP: Updating gdb-oneapi debugging reference docs roxx30198/numba-dpex
4 participants
@PokhodenkoSA @diptorupd @roxx30198 @mpuputti