Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The experimental.kernel should support all existing numba_dpex.tests.kernel_tests to verify experimental module has equivalent features #1395

Closed
diptorupd opened this issue Mar 20, 2024 · 0 comments · Fixed by #1400
Assignees

Comments

@diptorupd
Copy link
Contributor

diptorupd commented Mar 20, 2024

To verify that all core.kernel features are available in experimental the existing tests should be reviewed and equivalent tests should be added for the experimental kernel. Below is the matrix of current state:

Test name Status Notes
test_atomic_op Removed Superseded by new AtomicRef tests in experimental module.
test_barrier Removed Experimental needs a test for group_barrier with work-group scope.
test_caching Not applicable The feature is redundant as experimental module uses Numba's function overload caching.
test_complex_array Done Renamed to test_complex_array_kernel_arg
test_dpnp_ndarray_args Done
test_dump_kernel_llvm Done Tests for all configuration flags should be added in one place.
test_func_qualname_disambiguation Done
test_func_specialization Done The feature is not supported in experimental.device_func
test_func Done
test_invalid_kernel_args Done
test_kernel_has_return_value_error Done. #1394
test_kernel_launch_params Removed Experimental does need some negative tests for call_kernel
test_kernel_specialization Done
test_math_functions Done The number of existing tests is very inadequate.
test_ndrange_exceptions Done The test should be moved to tests/kernel_api and rewritten as a NdRange constructor test
test_print Done printimpl not yet added to new target context
test_private_memory_allocation Removed superseded by tests for kapi.PrivateArray
test_scalar_arg Done
test_sycl_usm_array_iface_interop Removed __SYCL_USM_ARRAY_INTERFACE__ support is slotted to be removed and for the time being only dpnp.ndarray and dpctl.tensor.usm_ndarray are valid arrya inputs. Interop is implemented indirectly using __dlpack__ conversion via dpnp/dpctl.tensor.
test_usm_ndarray_interop Done Renamed to test_usm_ndarray_args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant