Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide easily distinguishable kernel names #260

Closed
adarshyoga opened this issue Feb 18, 2021 · 1 comment · Fixed by #1112
Closed

Provide easily distinguishable kernel names #260

adarshyoga opened this issue Feb 18, 2021 · 1 comment · Fixed by #1112
Assignees
Labels
good first issue Good for newcomers

Comments

@adarshyoga
Copy link
Contributor

The names set by Numba-dppy for kernels generated from parfors are extremely long and make it impossible to determine what parfor they represent in the source code. Having easily distinguishable kernel names is extremely useful performance analysis of programs that have multiple kernels.

For easily distinguishable kernel names, I suggest the following protocol.
<file_name:function_name:line_number>
This combination is going to be unique for each kernel. If a parfor is called from outside a function, then it can be omitted and the combination of file_name and line_number (<file_name:line_number>) will still be unique.

@adarshyoga adarshyoga added the good first issue Good for newcomers label Mar 8, 2021
@diptorupd diptorupd self-assigned this Feb 21, 2023
@diptorupd
Copy link
Contributor

@adarshyoga I agree we need to fix the naming. The current naming is basically useless.

Expanding on your proposal, I suggest the following:

  1. Kernel name is a combination of the actual function name + a UUID that is based on the argument types.
  2. Parfor kernels follow the convention of function_name+loc+ UUID based on argument types
  3. Every kernel adds a metadata to LLVM IR showing the argument types

Can you help implement a solution? We can try and get it into 0.20?

@diptorupd diptorupd removed debug Related to #149 parfor Issues related to device offloading of `parallel for` code regions labels Feb 26, 2023
@diptorupd diptorupd assigned ZzEeKkAa and unassigned diptorupd May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants