Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing numba-dpex even if dpctl shows that there are no SYCL platforms #304

Closed
PokhodenkoSA opened this issue Apr 1, 2021 · 0 comments · Fixed by #1272
Closed
Assignees
Milestone

Comments

@PokhodenkoSA
Copy link
Contributor

Currently import numba-dppy raises exception if SYCL platform is not available.
https://github.com/IntelPython/numba-dppy/blob/6033fb832444e8e9fb5a0e12d300eaf4fdf438f9/numba_dppy/__init__.py#L527

It uses dpctl:
https://github.com/IntelPython/numba-dppy/blob/6033fb832444e8e9fb5a0e12d300eaf4fdf438f9/numba_dppy/config.py#L21

It means that if SYCL is not available we can not import numba-dppy and its tests at all.

Why not we able to import numba-dppy and run tests which do not use SYCL devices? We could skip all SYCL dependent tests but others could be run.

@diptorupd @reazulhoque
What do you think? Is it not too strict to prohibit import numba-dppy?

It is related to #38. It is confusing when installed package behaves like it is not installed.

@diptorupd diptorupd added this to the 0.22 milestone Dec 19, 2023
@diptorupd diptorupd changed the title Allow import numba-dppy even if dpctl shows that there are no SYCL platforms Allow importing numba-dpex even if dpctl shows that there are no SYCL platforms Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants