Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spirv-link fails when NUMBA_DPPY_DEBUG=1 #650

Closed
PokhodenkoSA opened this issue Nov 29, 2021 · 4 comments · Fixed by #1103
Closed

spirv-link fails when NUMBA_DPPY_DEBUG=1 #650

PokhodenkoSA opened this issue Nov 29, 2021 · 4 comments · Fixed by #1103
Assignees
Labels
bug Something isn't working
Milestone

Comments

@PokhodenkoSA
Copy link
Contributor

Scenario: "run dpbench gpairs workload"

NUMBA_DPPY_DEBUG=1 python run_gpairs.py --test --size 64
...
  File "/localdisk/work/spokhode/numba-dppy/numba_dppy/spirv_generator.py", line 115, in link
    check_call(["spirv-link", *flags, "-o", opath, *binaries])
  File "/localdisk/work/spokhode/numba-dppy/numba_dppy/spirv_generator.py", line 37, in check_call
    return _real_check_call(*args, **kwargs)
  File "/localdisk/work/spokhode/miniconda3/envs/dev/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['spirv-link', '--allow-partial-linkage', '-o', '/tmp/tmpzkvy2w_v/2-linked-spirv', '/tmp/tmpzkvy2w_v/1-generated-spirv', '/localdisk/work/spokhode/numba-dppy/numba_dppy/ocl/atomics/atomic_ops.spir']' returned non-zero exit status 1.
@PokhodenkoSA
Copy link
Contributor Author

@reazulhoque
Any ideas?

@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Nov 29, 2021

It works if native atomics enabled. Moving to native atomics will solve this problem automatically.

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Aug 2, 2023

Fixed in #1103

@diptorupd
Copy link
Contributor

Native atomics is enabled by default and emulated atomics code is removed. The problem most likely was the *.cl kernel for atomics emulation was not pre-compiled with -g when the debug flag was used it was linking to a binary without debug symbols.

Since, emulation is now removed the problem is no longer reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants