-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on llvm-spirv package and use llvm-spirv from dpcpp #778
Comments
An additional place where the fix should be applied is inside |
@mingjie-intel based on our discussion today, it will be best if dpex vendors llvm-spirv. The way we are doing it currently leaves us at mercy of user environment and is open to all sorts of issues. @oleksandr-pavlyk If we vendor a copy of llvm-spirv with dpex, how will it work for wheels based distributions? Do you foresee any issues? |
I think there is no problem with vendoring. It is a stand-alone ELF file which only depends on standard libraries, and no symbolic links are involved,
|
Done. numba-dpex now depends on the |
Right now
numba-dpex
depends on thellvm-spirv
package to generate SPIR-V from LLVM IR. Now thatdpcpp
compilers are available as Conda packages it should be possible to use thedpcpp
package to getllvm-spirv
.We should add
dpcpp
as a build and run dependency and remove the need to install llvm-spirv separately.But, tests should be done to ensure dpex still works for users who install it from pypi or build it from source without using conda. In that case, they are required to have llvm-spirv added to the PATH and dpex should have a run time check to see if the version requirements for llvm-spriv match our needs.
Most like #676 would also be fixed once we switch to using llvm-spirv from dpcpp.
The text was updated successfully, but these errors were encountered: