You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Parsing a URL with extra spaces result in wrong properties for protocols, protocol, pathname, name , href and full_name.
I'd like to propose a PR to trim the URL passed to the parser. However I'm not sure if you prefer to do that in git-url-parse, git-up, parse-url or parse-path.
I would imagine parse-path is the right place? Unless spaces are allowed at the beginning and end of path? I know they are not significant in URLs but not sure about FileSystem paths.
The text was updated successfully, but these errors were encountered:
Parsing a URL with extra spaces result in wrong properties for
protocols
,protocol
,pathname
,name
,href
andfull_name
.I'd like to propose a PR to trim the URL passed to the parser. However I'm not sure if you prefer to do that in
git-url-parse
,git-up
,parse-url
orparse-path
.I would imagine
parse-path
is the right place? Unless spaces are allowed at the beginning and end of path? I know they are not significant in URLs but not sure about FileSystem paths.The text was updated successfully, but these errors were encountered: