gradle conversion #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note for those who may be unfamiliar with Gradle: the Furthermore, the build can be performed with this command: |
|
@acoburn cool, completely unfamiliar with Gradle so thanks for that intro. |
|
@acoburn shall we hold off on merging this until after Wednesday's call? I noticed you put a item on the agenda. |
|
This look right? |
|
@ruebot looks good to me. Especially the |
|
@acoburn excellent. Follow-up question, will we always be using the bundled gradle from here on out? Or do we need it installed locally? |
|
@ruebot personally, I just use the version installed locally ( |
|
Cool. I'm good on this if @dannylamb is cool with moving to gradle. |
|
I know there isn't a whole lot in Alpaca, but it finished in Also, the config file is still confusing to me but there is a lot less of it than in Maven. Sooooo 👍 , and then I'll actually read the Gradle docs. |
|
Waiting to talk about it at CLAW call, but I'd be stunned to see someone rally for Maven. |
|
@whikloj one nice thing about Gradle is that there are docs and they are readable. @ruebot, @dannylamb this is now ready for final review. |
|
Clean: Second time: I'm good to merge, if you are @dannylamb. Then, I'm happy to take a crack at converting Salmon to |
|
I'm performing a multi-project release with gradle now on some local code and finding a few small things that will need to be added to this PR -- i.e. the build needs to generate javadoc and source jars, so I'll add (at least) one more commit before you merge this |
|
I finished the release for my other gradle-based project, and now that everything is set up, this is the extent of the process involved: first, in Then, run the following command: You will be prompted for the release and the next development version to use. Next, login to Sonatype to close and then release the artifact. I don't currently have a method for the equivalent of |
|
Turns out, I already had the site-deploy equivalent plugin added, it just wasn't wired into the release process. Now it is. |
|
@acoburn pulled down and tested again, all good on my end. @dannylamb you good with me merging? |
|
@ruebot fire away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Islandora/documentation#348
This is what the build system would look like with Gradle. AFAICT, it produces the same artifacts as the maven-based build. This setup also includes license and checkstyle verification (which are not present in the current build).
So, WDYT? Is it better? One thing is that the there's no XML (except for the checkstyle config, but there's no choice there). One thing to note is that even with the addition of the checkstyle and license configs (~130 lines), using Gradle uses significantly fewer lines of code for the same results.