-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcaster 448 #457
Broadcaster 448 #457
Conversation
@Islandora-CLAW/committers Now that #458 has landed, this is good to go. Can someone else please verify the install for me? As always, please squash and merge if this meets expectations. |
@dannylamb will test, since i'm devopping this week =) |
@dannylamb This is not working for me (means can't deploy vagrant) ==> default: Installing Islandora Triplestore Indexer |
@DiegoPino Do you still have that box floating around? Can you tell me if the ubuntu user's .m2 directory is owned by root still? |
Yeah, still have it:
|
@DiegoPino Crud... Even when compiled as the ubuntu user, it still is getting set to root somehow, even after chowning... I'll spin up another and see if I can sort it out. |
Worked for me
|
@dannylamb nope. Went clean again, all the way and this is the third time: Sorry, i suppose i can't be that wrong!. Made sure i was following all the steps. Any other ideas? OSX |
@DiegoPino Just checking my verification vagrant up and it's ok for me as well. CLAW commit is f0d2613, Alpaca commit on vagrant box is 83a4603174d19430ef9edc12f3edbb3760167447. I'm going to try obsessively chowning the local maven repository before and after compilation, AND before deploying the features file and we'll see if that works for you. If it does, I'll try and whittle it down to where it's going wrong so I don't have a bunch of unnecessary chowns floating around in the install. |
@dannylamb i'm probably not following the instructions correctly, can't imagine a different scenario. So you are fine to merge, don't be stopped by me. |
@whikloj If you're cool with this, can you merge it and Islandora/Alpaca#22 as well? |
@ruebot @Natkeeran @MarcusBarnes @bryjbrown |
@whikloj++ |
@whikloj I could possibly do it some time today. Worst case you get a late night message, or early morning message tomorrow. |
@ruebot thanks! I'm already doing it again from 0 (really 0, destroyed all my VMs by mistake!). If i got this passed, are you ok if i merge? |
Doing a |
Ok, done:
|
I'm on a clean clone, on master, and I'm getting what @DiegoPino got earlier:
|
@ruebot, i know the feeling 😢 i think i made a mistake (4 times, not once) that lead to that, because in the instructions there is a subtly implied action "Pull in the changes from this PR and then" that i probably did wrong in favor of the manual action. I think i did not that part correctly because the instructions further down looked more tempting 😄 for me. So if you do now a vagrant destroy then the manual changes in scripts/alpaca.sh it should work, maybe, at least it did this time for me. |
Sorry, I'm an idiot. I didn't check out @dannylamb's branch. I totally thought this was just a PR on Alpaca. |
@ruebot++ no idiot at all. It was not easy to follow. |
Ok! Good to go here. @whikloj I'll give you the honour to merge. |
This PR updates the install to include the changes from #448.
Testing Instructions
This will require you to spin up a new box, but since Islandora/Alpaca#22 won't be merged until you can test this, there's some extra hoops to jump through. Pull in the changes from this PR and then
cd /path/to/CLAW/install
vagrant destroy
sed -i 's|git clone https://github.com/Islandora-CLAW/Alpaca.git|git clone -b broadcaster-448 https://github.com/dannylamb/Alpaca.git|' scripts/alpaca.sh
vagrant up
Then once the VM is up and ready, you can test by verifying the feature has installed itself properly.
/opt/karaf/bin/client
And from within the Karaf console
The X means it's been installed.
You should also verify that the bundle is in the Active state
We're not set up for end-to-end integration testing yet (see #455), so in lieu of that, you can drop in this blueprint file in
/opt/karaf/deploy
and watch it go:From your karaf console, run
log:tail
and you should see the following fly by every ten seconds: