Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 640 #14

Merged
merged 10 commits into from
Nov 22, 2017
Merged

Issue 640 #14

merged 10 commits into from
Nov 22, 2017

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Islandora/documentation#640

What does this Pull Request do?

Culls stuff from Crayfish-Commons that's moved back into Crayfish (only used in one spot, and in theory should only be used there).

How should this be tested?

There's an upcoming Islandora-Devops/claw-playbook PR that we'll use to test all the PRs required for Islandora/documentation#640, since it encompasses Alpaca, Crayfish, Crayfish-Commons, the core Islandora module... pretty much all of it.

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Sep 28, 2017

Codecov Report

Merging #14 into master will increase coverage by 1.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #14      +/-   ##
===========================================
+ Coverage     75.68%   77.5%   +1.81%     
+ Complexity      117     109       -8     
===========================================
  Files             9       8       -1     
  Lines           440     400      -40     
===========================================
- Hits            333     310      -23     
+ Misses          107      90      -17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38657d3...da0e9a3. Read the comment docs.

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj whikloj merged commit 9434f75 into Islandora:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants