Adding the basics #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Expecting this to explode because of coding standards |
|
As expected, totally failing because of coding standards. I'll go ahead and patch it up here so everything is passing, but I'm going to rebase it to keep the standards commits separate. @Islandora-CLAW/committers when I do that, please don't squash and merge this PR. Just do a normal merge. |
|
Ok. Will try to merge on my way home |
|
@dannylamb if you need help with |
|
@DiegoPino We're green thanks to |
DiegoPino
approved these changes
Aug 23, 2017
|
@dannylamb simple merge or you prefer the rebase and merge? |
|
@DiegoPino Simple merge will do just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR template, license, contributing.md, and travis setup