Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use roles/external as the default location for ansible-galaxy install #174

Conversation

nigelgbanks
Copy link
Contributor

What does this Pull Request do?

If a user executes the following command:

ansible-galaxy install -r requirements.xml

The roles will be installed into roles/internal, since no specific path has been specified and the first path listed in the configuration is roles/internal.

This pull request changes this behaviour such that the default location it will install roles into is roles/external. This is useful for those who want to use the Ansible roles but do not with to use it via Vagrant (which specified the roles/external path explicitly).

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Default location of roles installation changed to roles/external rather than roles/internal

How should this be tested?

Execute the command:

ansible-galaxy install -r requirements.xml

Note that the roles are installed in the correct location without the need of also giving the explicit path.

Interested parties

@Islandora-Devops/committers

@dannylamb
Copy link
Member

dannylamb commented Apr 8, 2020

Can't tell you how many times this has annoyed me. 🙇‍♂️

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj whikloj merged commit 7bc4978 into Islandora-Devops:dev Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants