-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Make file for use again once build is working post-merge #26
Comments
Sounds like this is in progress from other people. I was going to add this
but I'll hand this back as I don't have much other input. |
@nikathone I'd like to assign this to you for testing again post-merge please. |
@g7morris sure. I should be able to test it before the end of the week. |
@nikathone During the course of your testing, can you review #6 specifically @nigelgbanks 's recommendation for a fix #6 (comment) The issue is that the Docker Compose project name doesn't match the Makefile From that PR:
|
Review Makefile again once we get build working with MVP3 and 2 merged.
Ensure that value of
docker_compose_project ?=
can be changed from hard-coded islandora to match .env value instead otherwise it appears Docker volumes and container names don't match and cause issuesReview @nigelgbanks 's suggestion here Drupal good default Initial PR #6 (comment) re
Minor non-issue. Should be added to .PHONY targets.
Update README or documentation with syntax in Make file, benefits of using and scripts / actions it assumes.
The text was updated successfully, but these errors were encountered: