Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Make file for use again once build is working post-merge #26

Closed
g7morris opened this issue Apr 16, 2020 · 4 comments
Closed

Update Make file for use again once build is working post-merge #26

g7morris opened this issue Apr 16, 2020 · 4 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@g7morris
Copy link
Collaborator

  • Review Makefile again once we get build working with MVP3 and 2 merged.

  • Ensure that value of docker_compose_project ?= can be changed from hard-coded islandora to match .env value instead otherwise it appears Docker volumes and container names don't match and cause issues

  • Review @nigelgbanks 's suggestion here Drupal good default Initial PR #6 (comment) re Minor non-issue. Should be added to .PHONY targets.

  • Update README or documentation with syntax in Make file, benefits of using and scripts / actions it assumes.

@g7morris g7morris added documentation Improvements or additions to documentation POST-MERGE labels Apr 16, 2020
@g7morris g7morris added bug Something isn't working documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 30, 2020
@noahwsmith
Copy link
Contributor

Sounds like this is in progress from other people. I was going to add this

jwt_keys:
	scripts/generate_jwt_keys.sh

but I'll hand this back as I don't have much other input.

@g7morris
Copy link
Collaborator Author

g7morris commented May 6, 2020

@nikathone I'd like to assign this to you for testing again post-merge please.

@g7morris g7morris removed their assignment May 6, 2020
@nikathone
Copy link
Member

@g7morris sure. I should be able to test it before the end of the week.

@g7morris
Copy link
Collaborator Author

g7morris commented May 7, 2020

@nikathone During the course of your testing, can you review #6 specifically @nigelgbanks 's recommendation for a fix #6 (comment)

The issue is that the Docker Compose project name doesn't match the Makefile

From that PR:

Is this partially due to line 5 in the Makefile? docker_compose_project ?= islandora

[Followup] interesting. I replaced islandora with docker_compose_project ?= isle_dc_proto2b on line 5 and got make: *** [Makefile:23: up] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants