Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shebangs to each shell script #55

Closed
ruebot opened this issue May 20, 2015 · 6 comments
Closed

Add shebangs to each shell script #55

ruebot opened this issue May 20, 2015 · 6 comments
Assignees

Comments

@ruebot
Copy link
Contributor

ruebot commented May 20, 2015

No description provided.

@ruebot ruebot self-assigned this May 20, 2015
@ruebot ruebot closed this as completed in 95bede6 May 20, 2015
@ruebot ruebot reopened this May 20, 2015
@ruebot
Copy link
Contributor Author

ruebot commented May 20, 2015

Since the shell scripts are being copied over to the remote filesystem during the build, some enviroment variables don't show up, and cause a lot of build failures. If we want to have shebangs in each shell script, then we'll need to determine an appropriate one for each, and make sure the correct environment variables come along with it.

@lo5an
Copy link
Contributor

lo5an commented May 23, 2015

I got curious and played around with this a little bit. It might be that we want #!/bin/bash instead of #!/bin/sh.

When I ran shellcheck on bootstrap.sh with #!/bin/sh, it reminded me that, for example:

In bootstrap.sh line 65:
debconf-set-selections <<< 'mysql-server mysql-server/root_password password islandora'
                           ^-- SC2039: In POSIX sh, here-strings are not supported.

@ruebot
Copy link
Contributor Author

ruebot commented May 23, 2015

If you want to take it on, I'm more than happy to reopen the issue.

@ruebot
Copy link
Contributor Author

ruebot commented May 24, 2015

Looks like it should be #!/bin/bash, and it seems to be working. I'll commit in push if this build is successful.

@ruebot ruebot reopened this May 24, 2015
@ruebot
Copy link
Contributor Author

ruebot commented May 24, 2015

Taken care of with 48d8866.

@ruebot ruebot closed this as completed May 24, 2015
@lo5an
Copy link
Contributor

lo5an commented May 24, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants