Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config in islandora_defaults has enforced dependency on islandora_core_feature #1478

Closed
dannylamb opened this issue Mar 31, 2020 · 1 comment
Labels
Type: enhancement Identifies work on an enhancement to the Islandora codebase

Comments

@dannylamb
Copy link
Contributor

All the config has

  enforced:
    module:
      - islandora_core_feature

which would make it uninstall if you uninstall islandora_core_feature. Feels like we should be removing this config when islandora_defaults is uninstalled.

@kstapelfeldt kstapelfeldt added Type: enhancement Identifies work on an enhancement to the Islandora codebase and removed enhancement labels Sep 25, 2021
@rosiel
Copy link
Member

rosiel commented Sep 16, 2022

We're deprecating Islandora Defaults. No config in its replacement, the Starter Site, should have ... oh. There are 84 configs in the starter site with enforced. This is indeed a problem.

I'd rather we remove the enforcement altogether. Right now, uninstalling the islandora_core_feature would remove so much it would make your site useless. For instance, it will remove every media type altogether. This is not useful.

Drupal already calculates dependencies for config items. The 'enforced' key is a way to manually create a dependency where there wasn't one.

I suggest we take out all enforced dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement Identifies work on an enhancement to the Islandora codebase
Projects
Development

No branches or pull requests

3 participants