Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: islandora_objects migration (migrate_7x_claw) lacks mapping for islandora:sp_pdf to field_model #1513

Open
kspurgin opened this issue May 20, 2020 · 2 comments
Labels
Type: bug identifies a problem in the software with clear steps to reproduce

Comments

@kspurgin
Copy link
Contributor

The result is the default (which maps to islandora_models Binary) is applied.

To fix this, I would add a line here mapping islandora:sp_pdf to islandora_models term "Digital Document" (https://schema.org/DigitalDocument).

This code seems to imply that this is the correct field_model value for nodes with PDF media. (?)

I am happy to create a PR with this update if it's appropriate. Lemme know.

@kspurgin
Copy link
Contributor Author

#925

@seth-shaw-unlv
Copy link
Contributor

PRs are always welcome, @kspurgin. Yes, "Digital Document" (https://schema.org/DigitalDocument) is the right one, although perhaps the tags migration is a bit more authoritative.

@kstapelfeldt kstapelfeldt added Type: bug identifies a problem in the software with clear steps to reproduce and removed bug labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug identifies a problem in the software with clear steps to reproduce
Projects
Development

No branches or pull requests

3 participants