Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Rights" field should have a maximum length greater than 255 characters #1636

Closed
mjordan opened this issue Oct 4, 2020 · 4 comments
Closed
Assignees
Labels
Type: enhancement Identifies work on an enhancement to the Islandora codebase

Comments

@mjordan
Copy link
Contributor

mjordan commented Oct 4, 2020

The "Rights" field (field_rights) created by Islandora Defaults has a maximum length of 255 characters. It's likely that many repositories will want a longer field. We may also want to change the field type from "Text (plain)" to "Text (plain, long)" to make its UI element be a text area instead of a single-line text field.

@mjordan mjordan self-assigned this Oct 4, 2020
@dannylamb
Copy link
Contributor

We should definitely change the default. Whether or not we provide an update hook ended ambiguously at the end of the last tech call. Personally I don't think it's neccessary given the nature of defaults and we're probably gonna break this big thang up anyway. But if we feel we must: https://evolvingweb.ca/blog/resizing-fields-drupal-8-without-losing-data

Seems pretty straighforward. If we do go that route, some of this could probably be generalized into utility functions.

@ruebot
Copy link
Member

ruebot commented Oct 15, 2020

Gonna throw a wrench in this...

Shouldn't the rights field be machine readable, or in Drupal terms just an entity reference? Then you can have terms setup for Rights Statements, Creative Commons, and Tradional Knowledge Labels for example? That'd probably hit #1234 as well, at least partially.

If there is a need for prosey rights statements or extra contextual metadata, those should just be a note based on my understanding of the RightsStatements.org Whitepaper, and displayed above the field.

@seth-shaw-unlv
Copy link
Contributor

So, yes and no. A lot of these default configs are designed to catch fields coming from Islandora 7 where this sort of field was free-text. We need to be able to catch whatever text folks already have in that field (which is why it needs to be longer). Although, following that thread, it should probably also be a formatted text field.

Here at UNLV, we have both a formatted text field with a default rights statement blurb that is specific to our Special Collections and Archives, but we also have a "Standardized Rights Statement" entity reference field to a rights statement taxonomy vocabulary.

So, this field should stay free-text, but there is nothing stopping anyone from implementing a rights statement field in addition to or in place of it locally.

@kstapelfeldt kstapelfeldt added Type: enhancement Identifies work on an enhancement to the Islandora codebase and removed architecture labels Sep 25, 2021
@rosiel
Copy link
Member

rosiel commented Oct 31, 2023

Rights has been changed in Islandora Starter Site to text (formatted, long). Agreed many folks will want a relation field (creative commons, rightstatements) but we're leaving that to the implementer.
Islandora-Devops/islandora-starter-site#102

@rosiel rosiel closed this as completed Oct 31, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Islandora Issues Queue Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement Identifies work on an enhancement to the Islandora codebase
Projects
Development

No branches or pull requests

6 participants