Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Openseadragon JS load order when BigPipe is enabled #1974

Open
jordandukart opened this issue Oct 25, 2021 · 0 comments
Open

Bug: Openseadragon JS load order when BigPipe is enabled #1974

jordandukart opened this issue Oct 25, 2021 · 0 comments
Labels
Type: bug identifies a problem in the software with clear steps to reproduce

Comments

@jordandukart
Copy link
Member

jordandukart commented Oct 25, 2021

In Islandora/openseadragon#26 OSD was moved over to use a CDN to serve up the OpenSeadragon library. With the big_pipe module enabled it's possible to run into racey scenarios where the external JS is not loaded prior to the instantiation of the viewer being done by the module itself.

We'd likely want to provide the end-user the ability to use a locally referenced copy of the library as opposed to the CDN such that the vast improvements that BigPipe provides can be leveraged.

See: https://www.drupal.org/project/geolocation/issues/3216917, https://www.drupal.org/project/webform/issues/3236382 and their related core issues.

@jordandukart jordandukart added the Type: bug identifies a problem in the software with clear steps to reproduce label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug identifies a problem in the software with clear steps to reproduce
Projects
Development

No branches or pull requests

1 participant