From 0305f46118e7f9ce1179afe9ee726e7135244286 Mon Sep 17 00:00:00 2001
From: Jkorf <jankorf91@gmail.com>
Date: Fri, 18 Oct 2024 14:52:47 +0200
Subject: [PATCH] Fixed
 restClient.GeneralApi.AutoInvest.GetSubscriptionTransactionHistoryAsync
 planId parameter being required

---
 Binance.Net/Binance.Net.xml                                   | 4 ++--
 .../GeneralApi/BinanceRestClientGeneralApiAutoInvest.cs       | 4 ++--
 .../GeneralApi/IBinanceRestClientGeneralApiAutoInvest.cs      | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Binance.Net/Binance.Net.xml b/Binance.Net/Binance.Net.xml
index a75f9b7d..5ecb9782 100644
--- a/Binance.Net/Binance.Net.xml
+++ b/Binance.Net/Binance.Net.xml
@@ -674,7 +674,7 @@
         <member name="M:Binance.Net.Clients.GeneralApi.BinanceRestClientGeneralApiAutoInvest.RedeemIndexLinkedPlanAsync(System.String,System.String,System.Int32,System.Threading.CancellationToken)">
             <inheritdoc />
         </member>
-        <member name="M:Binance.Net.Clients.GeneralApi.BinanceRestClientGeneralApiAutoInvest.GetSubscriptionTransactionHistoryAsync(System.Int64,System.Nullable{System.DateTime},System.Nullable{System.DateTime},System.String,System.Nullable{Binance.Net.Enums.AutoInvestPlanType},System.Nullable{System.Int32},System.Nullable{System.Int32},System.Threading.CancellationToken)">
+        <member name="M:Binance.Net.Clients.GeneralApi.BinanceRestClientGeneralApiAutoInvest.GetSubscriptionTransactionHistoryAsync(System.Nullable{System.Int64},System.Nullable{System.DateTime},System.Nullable{System.DateTime},System.String,System.Nullable{Binance.Net.Enums.AutoInvestPlanType},System.Nullable{System.Int32},System.Nullable{System.Int32},System.Threading.CancellationToken)">
             <inheritdoc />
         </member>
         <member name="M:Binance.Net.Clients.GeneralApi.BinanceRestClientGeneralApiAutoInvest.GetOneTimeTransactionStatusAsync(System.Int64,System.String,System.Threading.CancellationToken)">
@@ -6762,7 +6762,7 @@
             <param name="redemptionPercentage">Redemption percentage</param>
             <param name="ct">Cancellation token</param>
         </member>
-        <member name="M:Binance.Net.Interfaces.Clients.GeneralApi.IBinanceRestClientGeneralApiAutoInvest.GetSubscriptionTransactionHistoryAsync(System.Int64,System.Nullable{System.DateTime},System.Nullable{System.DateTime},System.String,System.Nullable{Binance.Net.Enums.AutoInvestPlanType},System.Nullable{System.Int32},System.Nullable{System.Int32},System.Threading.CancellationToken)">
+        <member name="M:Binance.Net.Interfaces.Clients.GeneralApi.IBinanceRestClientGeneralApiAutoInvest.GetSubscriptionTransactionHistoryAsync(System.Nullable{System.Int64},System.Nullable{System.DateTime},System.Nullable{System.DateTime},System.String,System.Nullable{Binance.Net.Enums.AutoInvestPlanType},System.Nullable{System.Int32},System.Nullable{System.Int32},System.Threading.CancellationToken)">
             <summary>
             Get subscription transaction history
             <para><a href="https://developers.binance.com/docs/auto_invest/trade/Query-subscription-transaction-history" /></para>
diff --git a/Binance.Net/Clients/GeneralApi/BinanceRestClientGeneralApiAutoInvest.cs b/Binance.Net/Clients/GeneralApi/BinanceRestClientGeneralApiAutoInvest.cs
index 776b83bc..6d3eda17 100644
--- a/Binance.Net/Clients/GeneralApi/BinanceRestClientGeneralApiAutoInvest.cs
+++ b/Binance.Net/Clients/GeneralApi/BinanceRestClientGeneralApiAutoInvest.cs
@@ -192,10 +192,10 @@ public async Task<WebCallResult<BinanceAutoInvestRedemptionResult>> RedeemIndexL
         #region Get Subscription Transaction History
 
         /// <inheritdoc />
-        public async Task<WebCallResult<IEnumerable<BinanceAutoInvestPlanTransaction>>> GetSubscriptionTransactionHistoryAsync(long planId, DateTime? startTime = null, DateTime? endTime = null, string? targetAsset = null, AutoInvestPlanType? planType = null, int? page = null, int? pageSize = null, CancellationToken ct = default)
+        public async Task<WebCallResult<IEnumerable<BinanceAutoInvestPlanTransaction>>> GetSubscriptionTransactionHistoryAsync(long? planId = null, DateTime? startTime = null, DateTime? endTime = null, string? targetAsset = null, AutoInvestPlanType? planType = null, int? page = null, int? pageSize = null, CancellationToken ct = default)
         {
             var parameters = new ParameterCollection();
-            parameters.Add("planId", planId);
+            parameters.AddOptional("planId", planId);
             parameters.AddOptionalMillisecondsString("startTime", startTime);
             parameters.AddOptionalMillisecondsString("endTime", endTime);
             parameters.AddOptional("targetAsset", targetAsset);
diff --git a/Binance.Net/Interfaces/Clients/GeneralApi/IBinanceRestClientGeneralApiAutoInvest.cs b/Binance.Net/Interfaces/Clients/GeneralApi/IBinanceRestClientGeneralApiAutoInvest.cs
index a5fbd194..c0ff9e1d 100644
--- a/Binance.Net/Interfaces/Clients/GeneralApi/IBinanceRestClientGeneralApiAutoInvest.cs
+++ b/Binance.Net/Interfaces/Clients/GeneralApi/IBinanceRestClientGeneralApiAutoInvest.cs
@@ -122,7 +122,7 @@ public interface IBinanceRestClientGeneralApiAutoInvest
         /// <param name="page">Current page</param>
         /// <param name="pageSize">Page size</param>
         /// <param name="ct">Cancellation token</param>
-        Task<WebCallResult<IEnumerable<BinanceAutoInvestPlanTransaction>>> GetSubscriptionTransactionHistoryAsync(long planId, DateTime? startTime = null, DateTime? endTime = null, string? targetAsset = null, AutoInvestPlanType? planType = null, int? page = null, int? pageSize = null, CancellationToken ct = default);
+        Task<WebCallResult<IEnumerable<BinanceAutoInvestPlanTransaction>>> GetSubscriptionTransactionHistoryAsync(long? planId = null, DateTime? startTime = null, DateTime? endTime = null, string? targetAsset = null, AutoInvestPlanType? planType = null, int? page = null, int? pageSize = null, CancellationToken ct = default);
 
         /// <summary>
         /// Get one time transaction status