Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/emit errors with no errors #71

Merged
merged 3 commits into from
Feb 22, 2017
Merged

Fix/emit errors with no errors #71

merged 3 commits into from
Feb 22, 2017

Conversation

JaKXz
Copy link
Contributor

@JaKXz JaKXz commented Feb 22, 2017

Fixes #69.

This was referenced Feb 22, 2017
Closed
Closed
@coveralls
Copy link

coveralls commented Feb 22, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 98.734% when pulling a760e55 on fix/emitErrors-with-no-errors into 4d4d233 on master.

@JaKXz
Copy link
Contributor Author

JaKXz commented Feb 22, 2017

@nijk if you could try npm install JaKXz/stylelint-webpack-plugin#fix/emitErrors-with-no-errors, it should fix the error you reported earlier.

@JaKXz JaKXz merged commit 154b405 into master Feb 22, 2017
@JaKXz JaKXz deleted the fix/emitErrors-with-no-errors branch February 22, 2017 20:28
@nijk
Copy link

nijk commented Feb 22, 2017

@JaKXz Thanks for looking at this so quickly. I can confirm the fix works for the reported issue. Nice use of Ramda! Any chance you could tag master/publish to NPM so that I can pull this into my project by version?

@JaKXz
Copy link
Contributor Author

JaKXz commented Feb 24, 2017 •
edited
Loading

@nijk will do so mid-next week when I have OSS cycles again - in the meantime I'm hoping folks can find bugs like you did :)

@JaKXz
Copy link
Contributor Author

JaKXz commented Feb 24, 2017

+ [email protected] published! Thanks for your patience.

joshwiens pushed a commit that referenced this pull request Mar 31, 2018
@JaKXz @joshwiens
fix(emitErrors): no console output when file(s) are clean (#71)
d0ab9c9 
* tests: add test for lint-free + emitErrors case

and use const for assured block scoping

* fix: use helper functions for results filtering

* fix: remove unneeded lodash.defaultTo dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaKXz @coveralls @nijk