Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langid field not provided if not already present in the entry #6576

Closed
1 task done
crystalfp opened this issue Jun 3, 2020 · 9 comments
Closed
1 task done

langid field not provided if not already present in the entry #6576

crystalfp opened this issue Jun 3, 2020 · 9 comments
Labels
status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@crystalfp
Copy link

JabRef 5.1--2020-05-29--ed275b6
Windows 10 10.0 amd64
Java 14.0.1

The field "langid" is no more offered by the entry editor. If the field is already present in the .bib file it appears in the editor under "Other fields" tab. This field is needed for multi-language bibliographies.

Steps to reproduce the behavior:

  1. Create a new entry of type "Article" or "InProceedings"
  2. The field "langid" is not present
  3. Open a bib file with an entry that has the langid field.
  4. Note the langid field is accessible in JabRef
@Siedlerchr
Copy link
Member

JabRef only provides the field language. However, you can simply add the field langid to the entry types using the Customize Entry types dialog.
Just type in langid in the field combobox and add it as required or optional

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jun 3, 2020
@crystalfp
Copy link
Author

OK, this works. Thanks for remembering me JabRef functionalities I never used. But:

  1. I added langid as optional, but the + button is disabled, I have to click in the other (left) field to have it enabled.
  2. The dropdown menu of this field is useless because it lists only few field, seems the ones already added, so I have to type langid
  3. In the editor the new field is added at the beginning, not in alphabetical order. This is quite distracting.
    Maybe now this issue could become a usability bug.
    Thanks for considering!

@Siedlerchr
Copy link
Member

We are already working on improving the handling and manually defining an order which will be used in the entry editor as well
Refs #6152 and #6338

@crystalfp
Copy link
Author

OK, so the solution is already in the making. Perfect, thanks! So I close this issue.

@Siedlerchr
Copy link
Member

Siedlerchr commented Jun 14, 2020

@crystalfp The order of the fields in the CustomEntryTypesDialog now reflects the order of the fields in the entry editor. Note that it still distinguishes between optional/required fields. Fields are grouped by required/optional.
The fields can be reordered with drag and drop.
The "+" Button is now enabled once you leave the combobox

I would like you to test the current implementation. Maybe you have some ideas how to imrpove the user experience
https://builds.jabref.org/pull/6152/merge/
Please remember to make a backup of your library before trying out this verison.

@crystalfp
Copy link
Author

Thanks @Siedlerchr ! The drad-and-drop works, but it has no effect on the ordering in the entry editor. I put the evergreen langid as optional after Number, but in the editor it comes as first entry in the Optional fields tab.

@Siedlerchr
Copy link
Member

Thanks, indeed I could reproduce it. It seems this ordering does not work when it's a non standard field.

@Siedlerchr
Copy link
Member

@crystalfp Could you please test the latest build from here https://builds.jabref.org/pull/6152/merge/ again?
The issue with the order is now resolved.

@crystalfp
Copy link
Author

OK, seems to work. The only minor thing is the spacing of the added item in the list. In the Optional Fields tab below I added the langid field:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

2 participants