-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show preview of the selected theme #12104
base: main
Are you sure you want to change the base?
Show preview of the selected theme #12104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove AI generated comments.
Remove image (not linked in the docs)
@@ -10,7 +10,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
## [Unreleased] | |||
|
|||
### Added | |||
|
|||
- We added a preview for themes, when they are selected in preferences (to solve: https://github.com/JabRef/themes.jabref.org/issues/10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong format.
Does not solve the original issue and does not work for custom themes, although I like the idea |
Solves issue 10 in the JabRef Themes Repo: JabRef/themes.jabref.org#10
It added a preview of the light and dark theme when the user selects it.
The preview is removed if the user does not change their theme or chooses a custom them.
Dark Theme Preview:
Light Theme Preview:
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)