Added keybinding for renaming group with F2 #12159

Rydzard · 2024-11-05T12:47:57Z

Describe the changes you have made here: what, why, ...
Link the issue that will be closed, e.g., "Closes #333". If your PR closes a koppor issue, link it using its URL, e.g., "Closes koppor#47".

Mandatory checks

I own the copyright of the code submitted and I licence it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Rydzard · 2024-11-05T12:49:58Z

Hello. I added the Rename Group to the context menu with keybinding (for now I set it to the letter R, because I couldn't try F2 locally, I will change it to F2 in the finale). I just have one problem, that when I change the name of the group, the groups become smaller (I will also send a video example). Can you advise me why it does this and how I could fix it?

Video : https://github.com/user-attachments/assets/396d439e-ca00-451c-991b-43f12666bc72

github-actions

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

Siedlerchr · 2024-11-06T23:25:02Z

Code wise looks okay to me so far, but I haven't an idea why the group size changes. Does this happen with the normal dialog as well?
Can you pleaes fix the failing checkstyle test?

github-actions

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

github-actions

JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

koppor · 2024-11-11T23:13:29Z

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

+    /**
+     * Opens "Rename Group Dialog" and change name of group
+     */
+


Why the empt yline?

Removed empty line

koppor · 2024-11-11T23:13:40Z

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

+    public void renameGroup(GroupNodeViewModel oldGroup) {
+        currentDatabase.ifPresent(database -> {
+            AbstractGroup oldGroupDef = oldGroup.getGroupNode().getGroup();
+            String oldGroupName = oldGroupDef.getName(); // Zachytenie starého názvu pred otvorením dialógu


Please translate the comment (or remove it)

koppor · 2024-11-11T23:14:22Z

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

+                    return;
+                }
+
+                // check if is not include ","


Remove comment - the next line says the same.

The WHY is important. Why is this check done.

Hello. I removed this comment. I check this because I inspired by Edit group where this check too. I can remove this if-statement if you want.

koppor · 2024-11-11T23:14:31Z

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

+                    return;
+                }
+
+                // chceck if old group name dont equels with new group name


Remove comment - next line says it

src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

koppor · 2024-11-11T23:16:33Z

src/main/java/org/jabref/gui/groups/RenameGroupView.java

+        nameField = new TextField();
+        nameField.setPromptText("Enter new group name");
+
+        // add Input


koppor · 2024-11-11T23:16:47Z

src/main/java/org/jabref/gui/groups/RenameGroupView.java

+        getDialogPane().getButtonTypes().setAll(ButtonType.OK, ButtonType.CANCEL);
+
+        nameField = new TextField();
+        nameField.setPromptText("Enter new group name");


Use Localiaztion.lang - see https://devdocs.jabref.org/code-howtos/localization.html

koppor · 2024-11-11T23:16:53Z

src/main/java/org/jabref/gui/groups/RenameGroupView.java

+        nameField.setPromptText("Enter new group name");
+
+        // add Input
+        VBox vbox = new VBox(new Label("New group name:"), nameField);


Use Localiaztion.lang - see https://devdocs.jabref.org/code-howtos/localization.html

No ":"

koppor · 2024-11-11T23:16:59Z

src/main/java/org/jabref/gui/groups/RenameGroupView.java

+        VBox vbox = new VBox(new Label("New group name:"), nameField);
+        getDialogPane().setContent(vbox);
+
+        // If press OK change name else return null


koppor · 2024-11-11T23:17:03Z

src/main/java/org/jabref/gui/groups/RenameGroupView.java

+            if (buttonType == ButtonType.OK) {
+                return resultConverter(ButtonType.OK).orElse(null);
+            } else {
+                // Ak sa zvolí Cancel alebo sa dialóg zavrie cez X


github-actions

JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

…renameGroup

Rydzard · 2024-11-18T21:02:44Z

Hello @koppor @Siedlerchr . I have a small problem with Unit Test findMissingLocalizationKeys(). I added strings to JabRef_en.properties, but this test on my local computer still shows error that I dont have string in this file. Can someone tell, what I have done wrong please?

github-actions

JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

Siedlerchr · 2024-11-19T16:23:55Z

That looks correct at first sight . Maybe some caching. Can you push the modifications? Then we can see if it works on CI

github-actions

JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

github-actions

JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

github-actions

JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

Added keybinding for renaming group with F2

42616e2

Rydzard mentioned this pull request Nov 5, 2024

Add "Rename group" to group context menu and add keybinding for F2 #11896

Open

github-actions bot reviewed Nov 5, 2024

View reviewed changes

fix group size changes

ea811f1

github-actions bot reviewed Nov 11, 2024

View reviewed changes

fix checkstyleTest

8144433

github-actions bot reviewed Nov 11, 2024

View reviewed changes

Discard changes to src/main/java/org/jabref/gui/DialogService.java

20c387a

koppor requested changes Nov 11, 2024

View reviewed changes

koppor added the status: changes required Pull requests that are not yet complete label Nov 11, 2024

github-actions bot reviewed Nov 11, 2024

View reviewed changes

Richard Dulák added 2 commits November 18, 2024 21:35

remove comments etc.

67a5d5f

Merge branch 'renameGroup' of https://github.com/Rydzard/jabref into …

5dcc5a2

…renameGroup

remove comments etc.

487754a

github-actions bot reviewed Nov 18, 2024

View reviewed changes

Richard Dulák and others added 2 commits November 22, 2024 21:51

try CI

a3e8599

Merge branch 'main' into renameGroup

bfa8228

github-actions bot reviewed Nov 22, 2024

View reviewed changes

DeleteTest

645693b

github-actions bot reviewed Nov 22, 2024

View reviewed changes

return FetcherTest

75f84bc

github-actions bot reviewed Nov 22, 2024

View reviewed changes

Update JabRef_en.properties

068253c

Rydzard requested a review from koppor November 22, 2024 23:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added keybinding for renaming group with F2 #12159

Added keybinding for renaming group with F2 #12159

Rydzard commented Nov 5, 2024 •

edited

Loading

Rydzard commented Nov 5, 2024

github-actions bot left a comment

Siedlerchr commented Nov 6, 2024

github-actions bot left a comment

github-actions bot left a comment

koppor Nov 11, 2024

Rydzard Nov 18, 2024

koppor Nov 11, 2024

Rydzard Nov 18, 2024

koppor Nov 11, 2024

Rydzard Nov 18, 2024

koppor Nov 11, 2024

Rydzard Nov 18, 2024

koppor Nov 11, 2024

Rydzard Nov 18, 2024

koppor Nov 11, 2024

Rydzard Nov 18, 2024

koppor Nov 11, 2024

Rydzard Nov 18, 2024

koppor Nov 11, 2024

Rydzard Nov 18, 2024

koppor Nov 11, 2024

Rydzard Nov 18, 2024

github-actions bot left a comment

Rydzard commented Nov 18, 2024 •

edited

Loading

github-actions bot left a comment

Siedlerchr commented Nov 19, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

Added keybinding for renaming group with F2 #12159

Are you sure you want to change the base?

Added keybinding for renaming group with F2 #12159

Conversation

Rydzard commented Nov 5, 2024 • edited Loading

Mandatory checks

Rydzard commented Nov 5, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

Siedlerchr commented Nov 6, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Rydzard commented Nov 18, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

Siedlerchr commented Nov 19, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Rydzard commented Nov 5, 2024 •

edited

Loading

Rydzard commented Nov 18, 2024 •

edited

Loading