Markdown Export Formatter #12220
Open
Markdown Export Formatter #12220
+203
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
calixtus
reviewed
Nov 22, 2024
There was a problem hiding this comment.
One suggestion about Changelog, other things look ok-ish to me.
As noone asked for this feature yet, i guess you will be the only one for a long time to use it, so opinionated implementation is fine for me.
What im not sure of is a custom SaveOrder hardcoded. Opinions?
Co-authored-by: Carl Christian Snethlage <[email protected]>
LinusDietz
added
type: feature
status: ready-for-review
Siedlerchr
reviewed
Nov 22, 2024
| @@ -27,6 +30,7 @@ public static ExporterFactory create(CliPreferences preferences) { | |||
| List<TemplateExporter> customFormats = preferences.getExportPreferences().getCustomExporters(); | |||
| LayoutFormatterPreferences layoutPreferences = preferences.getLayoutFormatterPreferences(); | |||
| SelfContainedSaveOrder saveOrder = SelfContainedSaveOrder.of(preferences.getSelfContainedExportConfiguration().getSaveOrder()); | |||
| SelfContainedSaveOrder saveMostRecentFirst = new SelfContainedSaveOrder(SaveOrder.OrderType.SPECIFIED, List.of(new SortCriterion(StandardField.YEAR, true))); | |||
There was a problem hiding this comment.
I would simply use the save order from the preferences, just for consistency and to reduce wtfs ;)
Siedlerchr
approved these changes
Nov 22, 2024
|
Yes, preferences save order. Maybe we can make it somewhat customizable in the layout files in a follow up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I quickly implemented an export format in a specific (admittedly, opinionated) format to Markdown... I find the format useful to put on websites that uses Markdown as input format website.
For anybody who's interested, the command I use to generate the list of the website is:
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)