Internal error triggered by ProphesizeDynamicReturnTypeExtension::getTypeFromMethodCall with phpspec/prophecy 1.18

[InvisibleSmiley]

Steps required to reproduce the problem

1. Start with a project using phpstan/phpstan 1.10.48, phpstan/phpstan-phpunit 1.13.15, phpspec/prophecy dev-master, phpspec-prophecy-phpunit dev-master, and some tests using Prophecy like (new Prophet())->prophesize(Some::class)
2. Upgrade phpspec/prophecy to 1.18 (from dev-master)

Expected Result

• PHPStan finished without internal errors

Actual Result

• PHPStan runs into an internal error

Xdebug analysis shows that the difference before/after is in ProphesizeDynamicReturnTypeExtension::getTypeFromMethodCall line 70 where the $returnType instanceof check used to be true but is not anymore:

• before: GenericObjectType
• after: ConditionalTypeForParameter

[danepowell]

Definitely a regression in 1.18. Here's a full stacktrace: phpstan/phpstan#10272 (comment)

[danepowell]

Since this appears to be a breaking change in phpspec/prophecy, is it worth opening an issue there?

[nikophil]

Hello @danepowell

is there an issue opened in phpspec/prophecy? I can't find it

[danepowell]

I've not had time to open an issue with phpspec/prophecy

[JustusNBB]

I think I've also hit this: phpstan/phpstan#10582
Would you please confirm it's the same issue? Any chance of getting #316 merged soon?

[danepowell]

Since this appears to be a breaking change in phpspec/prophecy, is it worth opening an issue there?

To be clear, I proposed opening an issue in phpspec/prophecy only to document (and to some degree, complain about 😄 ) the undocumented breaking change. But ultimately, I think this needs to be fixed via #316