-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RL] Review RL brains and update documentation #141
Comments
This issue comes from the previous one -> #140 |
Hi So we will derive the RL brain from one of the DL brain base classes, right? If not, what approach do you plan? |
I guess the idea is to review the RL part and make it work again so we shouldn't use any no RL based brain for this task. We don't need to generate a new brain now but just fix the ones already in the project (RL part). Thanks for the brain, we can review and add it later on but this task has the maximum priority now. Without it fixed, we can't merge your brain. |
Hi Sergio I have some doubts.
|
It actually is different. The RL pipeline is based on gym-gazebo, a combination of OpenAI Gym and Gazebo that has everything related to RL inside (if you follow the calls that's where the workflow is heading after that line you comment). There is a folder with gym-gazebo in the project root and it comes from this repo and is now under development by our org here. It will be a separated project soon by for now it's integrated in here. The DL pipeline doesn't need the OpenAI gym part. |
Hi Yes, I followed everything and I verified that whatever is required already exists in the same form as @dcharrezt formulated in his latest commit on the RL setup. Thanks |
I can't assure that the problem comes from gym-gazebo but I believe that it's related with Behavior Studio itself. You could go back to the version of Behavior Studio from last @dcharrezt commit (somewhere in August) and verify that that version is also broken |
Thank you very much! |
I solved the problem with the RL brains. It was related with some circuits path changes and the motors publisher. Now you should be able to run both DL and RL based brains. For the DL brains, use
Please try it out and tell me if that worked for you. |
RL brains are currently broken, so a review of that workflow is needed.
Update the documentation about that RL brains is also needed.
The text was updated successfully, but these errors were encountered: