Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect temporary folder for the cat-vs-dogs dataset #161

Closed
zaleslaw opened this issue Jul 27, 2021 · 7 comments · Fixed by #235
Closed

Incorrect temporary folder for the cat-vs-dogs dataset #161

zaleslaw opened this issue Jul 27, 2021 · 7 comments · Fixed by #235
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@zaleslaw
Copy link
Collaborator

zaleslaw commented Jul 27, 2021

WE have incorrect paths in the embeddedDatasets.kt: the temporary data.zip is loaded to the datasets/catdogs/data.zip instead of datasets/dogs-vs-cats/data.zip

  1. Fix the issue
  2. Refactor String constants moving common parts to one common constant
  3. Check that the loading is correct with one of these examples in the cache directory
@zaleslaw zaleslaw added bug Something isn't working good first issue Good for newcomers labels Jul 27, 2021
@zaleslaw zaleslaw modified the milestones: 0.2, 0.3 Jul 27, 2021
@funkstermonster
Copy link

Hi! I started working on it. Can I have access this repo to assign it for me?

@funkstermonster
Copy link

I commited the solution. Would be grateful, if I could push them to a separate branch and open a pr.

@mkaze
Copy link
Contributor

mkaze commented Jul 27, 2021

@funkstermonster Thank your for your interest and contribution. You should first fork this repository and push your commits to your own fork on Github. Then you will be able to make a Pull Request (PR) to merge your changes to this repository. Please see this guide for more info: https://github.com/firstcontributions/first-contributions#first-contributions

Also, please review the contributing guidelines of KotlinDL here.

@funkstermonster
Copy link

funkstermonster commented Jul 27, 2021

I might have troubles linking the issue and the PR together, since the cog icon is missing for me.

@mkaze
Copy link
Contributor

mkaze commented Jul 28, 2021

I might have troubles linking the issue and the PR together, since the cog icon is missing for me.

@funkstermonster You just need to use one of the special keywords followed by the issue number in the PR description to link them together. See this guide for some help and examples.

@funkstermonster
Copy link

Thank you for your help. Linked the issue.

@zaleslaw
Copy link
Collaborator Author

Thanks for the help for newcomers, @mkaze ! You are the best!
Dear @funkstermonster I'll do the review during the next 2 days and answer you in the linked PR
Welcome to the KotlinDL

@zaleslaw zaleslaw assigned zaleslaw and unassigned funkstermonster Sep 21, 2021
@zaleslaw zaleslaw linked a pull request Sep 21, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
3 participants