Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tanh shrink activation function #172

Closed
5 tasks
zaleslaw opened this issue Jul 29, 2021 · 5 comments · Fixed by #200
Closed
5 tasks

Add Tanh shrink activation function #172

zaleslaw opened this issue Jul 29, 2021 · 5 comments · Fixed by #200
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@zaleslaw
Copy link
Collaborator

The TanhShrinkactivation function is missed in KotlinDL.

The desired PR addressing this issue should include:

  • Implementation of activation class named as TanhShrinkActivation (you can take inspiration from the implementation of HardSigmoid as reference) added to the Activations.kt file
  • Documentation of activation function
  • JUnit tests in api module
  • Support for export of activation function to JSON (see ModelSaver.kt)
  • Support for import of activation function from JSON (see ModelLoader.kt)

P.S. If you want to take this ticket, please leave the comment below
P.P.S Read the Contributing Guidelines.

The reference implementation could be taken from tensorflow-addons

@zaleslaw zaleslaw added the good first issue Good for newcomers label Jul 29, 2021
@zaleslaw zaleslaw added this to the 0.3 milestone Jul 29, 2021
@femialaka
Copy link
Contributor

I would like to work on this one, can you please send me a slack invite so I can discuss a few things, thanks in advance.

@zaleslaw
Copy link
Collaborator Author

No need special invites to the kotlin slack, just register with your e-mail. Also, you could free ask me here, in this issue

@femialaka
Copy link
Contributor

When I was trying to run irisClassification in the examples I got the following error:

"No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again"

Process finished with exit code 134 (interrupted by signal 6: SIGABRT)

I ran it on a Mac with an M1 chip I suspect this may be the cause?

@zaleslaw
Copy link
Collaborator Author

Hi @femialaka please see the following bug

The KotlinDL internally uses TF 1.15 runtime, which means you can use it only with the previous Mac without M1.

But I got different errors for the different combinations of OS and architectures. Could you please share with me the OS X version?

@femialaka
Copy link
Contributor

femialaka commented Aug 17, 2021

@zaleslaw sure, its Big Sur version 11.5.2 (M1 2020), I'll try another machine then and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants