-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tanh shrink activation function #172
Comments
I would like to work on this one, can you please send me a slack invite so I can discuss a few things, thanks in advance. |
No need special invites to the kotlin slack, just register with your e-mail. Also, you could free ask me here, in this issue |
When I was trying to run irisClassification in the examples I got the following error: "No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again" Process finished with exit code 134 (interrupted by signal 6: SIGABRT) I ran it on a Mac with an M1 chip I suspect this may be the cause? |
Hi @femialaka please see the following bug The KotlinDL internally uses TF 1.15 runtime, which means you can use it only with the previous Mac without M1. But I got different errors for the different combinations of OS and architectures. Could you please share with me the OS X version? |
@zaleslaw sure, its Big Sur version 11.5.2 (M1 2020), I'll try another machine then and get back to you. |
The TanhShrinkactivation function is missed in KotlinDL.
The desired PR addressing this issue should include:
TanhShrinkActivation
(you can take inspiration from the implementation ofHardSigmoid
as reference) added to theActivations.kt
fileapi
moduleP.S. If you want to take this ticket, please leave the comment below
P.P.S Read the Contributing Guidelines.
The reference implementation could be taken from tensorflow-addons
The text was updated successfully, but these errors were encountered: