Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model export for a few layers, missed in ModelSaver.kt #87

Closed
zaleslaw opened this issue Jun 1, 2021 · 1 comment · Fixed by #88
Closed

Add model export for a few layers, missed in ModelSaver.kt #87

zaleslaw opened this issue Jun 1, 2021 · 1 comment · Fixed by #88
Assignees
@mkaze
Labels
good first issue Good for newcomers
Milestone
0.3

Comments

@zaleslaw
Copy link
Collaborator

zaleslaw commented Jun 1, 2021 •
edited
Loading

Each layer should be exported in JSON, Keras compatible format
The following layers are missed in ModelSaver.kt

  1. Concatenate
  2. ZeroPadding2D
  3. DepthwiseConv2D
  4. SeparableConv2D

NOTE: some another layers' export, like Activation or merge layers like Subtract and so on are parts of other PRs now
@zaleslaw zaleslaw added the good first issue Good for newcomers label Jun 1, 2021
@zaleslaw zaleslaw added this to the 0.3 milestone Jun 1, 2021
@mkaze
Copy link
Contributor

mkaze commented Jun 1, 2021 •
edited
Loading

I'll take this one. By the way, export of ZeroPadding2D layer is already supported.

@mkaze mkaze mentioned this issue Jun 1, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaze mkaze

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

Add missing export functionality for more layers mkaze/KotlinDL
2 participants
@zaleslaw @mkaze