Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Incompatibility with promethus/pushgateway:0.10.0 #120

Open
Gounlaf opened this issue Oct 14, 2019 · 0 comments · May be fixed by #122
Open

Incompatibility with promethus/pushgateway:0.10.0 #120

Gounlaf opened this issue Oct 14, 2019 · 0 comments · May be fixed by #122

Comments

@Gounlaf
Copy link

Gounlaf commented Oct 14, 2019

Hi,

Version 0.10.0 of promethus/pushgateway introduced a change in response:

[CHANGE] Check pushed metrics immediately and reject them if inconsistent. Successful pushes now result in code 200 (not 202)

Current version of this client doesn't support it, throwing an exception (see below)

prometheus_client_php/src/Prometheus/PushGateway.php

Line 85 in 215c9ae

if ($statusCode != 202) {

@bvisness bvisness linked a pull request Oct 16, 2019 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent exception from being thrown on 200 wheniwork/prometheus_client_php
1 participant
@Gounlaf