Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark persists when navigating through publications using the linked visualisation #190

Open
shaunajisc opened this issue Jul 8, 2022 · 1 comment
Labels
ui In relation to project ui

Comments

@shaunajisc
Copy link
Contributor

When a user bookmarks a publication, and then navigates through the linked publications using the linked visualisation the bookmark icon remains filled in, and users are unable to interact with the feature for other publications. This is only an issue when you are navigating through publications using the visualisation. If you were to access the same publication via the search pages or to manually refresh the page, the bookmark refreshes and shows the right state depending on the data.

I think this is an issue with how the publication is being loaded into the page, as it seems that the data isn't being checked before the bookmark renders on the screen, the data is just pulled through from the previous publication. But further investigation is needed.

Screen.Recording.2022-07-08.at.12.04.17.mov
@shaunajisc shaunajisc added the ui In relation to project ui label Jul 8, 2022
@AshleyRedman
Copy link
Contributor

I imagine the bookmark data needs to come from the SWR source & not from SSR, this was a problem a few months ago but seems to have been fixed elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui In relation to project ui
Projects
None yet
Development

No branches or pull requests

2 participants