fix: No more adding infinite boolean for function returning promise #1481
Conversation
| return await navigateByUrl(""); | ||
| } | ||
|
|
||
| async function navigateTo2(): Promise<boolean> | boolean { |
There was a problem hiding this comment.
Note,
async function navigateTo(): Promise<boolean> | boolean {andasync function navigateTo2(): Promise<boolean> | boolean {are wrong. Both should return onlyPromise<boolean>. I can remove those from the test but I wanted to keep them to see, the difference.
Yeah that looks like an existing unrelated issue. Up for a followup? 😄
There was a problem hiding this comment.
Yeah that looks like an existing unrelated issue. Up for a followup?
Yeah. I think I have now understood that many of the issues that I'm seeing, are coming from the root cause that TypeStat does not understand that it should be adding more types to inside Promise.
| @@ -6,6 +6,8 @@ import { setSubtract } from "../../shared/sets.js"; | |||
| const knownTypeFlagEquivalents = new Map([ | |||
| [ts.TypeFlags.BigInt, ts.TypeFlags.BigIntLiteral], | |||
| [ts.TypeFlags.BigIntLiteral, ts.TypeFlags.BigInt], | |||
| [ts.TypeFlags.Boolean, ts.TypeFlags.BooleanLiteral], | |||
| [ts.TypeFlags.BooleanLiteral, ts.TypeFlags.Boolean], | |||
There was a problem hiding this comment.
It was this small change in the end??
😄 a lot of these little bugs are! Nice find though, this is a really good fix.
|
@all-contributors please add @rubiesonthesky for code.
|
|
@rubiesonthesky already contributed before to code I couldn't determine any contributions to add, did you specify any contributions? |
PR Checklist
status: accepting prsOverview
It was this small change in the end??
Note,
async function navigateTo(): Promise<boolean> | boolean {andasync function navigateTo2(): Promise<boolean> | boolean {are wrong. Both should return onlyPromise<boolean>. I can remove those from the test but I wanted to keep them to see, the difference.