-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add bin to package.json #1508
fix: add bin to package.json #1508
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
+ Coverage 80.25% 80.27% +0.01%
==========================================
Files 172 172
Lines 10825 10846 +21
Branches 1040 1040
==========================================
+ Hits 8688 8707 +19
- Misses 2132 2134 +2
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I changed build workflow so that it tries to run the cli. And now we can see that the cli is working in CI too. |
Coverage change is because the auto format changes due using default import. I guess I need to add prompt variable so the formatting does not need to change. |
Agreed. I'm a bit swamped this week but will try to get through this and #1515 soon! |
No worries. To make checking this easier, this is how I tested locally (same as in the CI) :)
|
@@ -5,7 +5,8 @@ jobs: | |||
- uses: actions/checkout@v4 | |||
- uses: ./.github/actions/prepare | |||
- run: pnpm build | |||
- run: node ./lib/index.js | |||
- run: pnpm link . | |||
- run: pnpm typestat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL of this strategy, I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just getting back to this now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Given that 0.8.0 is broken and this PR's branch works for me, I'm just going to release this to the wild. 🚀 |
PR Checklist
status: accepting prs
Overview
I think it would be good idea to do alpha / experimental release after this to check that everything is correct :)