Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix mutation test not actually reading tsconfig #1511

Merged

Conversation

rubiesonthesky
Copy link
Collaborator

@rubiesonthesky rubiesonthesky commented Apr 1, 2024

PR Checklist

Overview

  • Refactor file reading in testSetup.ts
  • Fix reading tsConfig settings

Some files changed to be what they should be, and some are now exposing bugs (test/cases/fixes/incompleteTypes/returnTypes/expected.ts) .

I'm not sure why the type is being removed in test/cases/fixes/noInferableTypes/variableDeclarations/expected.ts but I think this is also exposing some type. Or it may be that Map would need some different tsconfig settings. - Filed new issue about it #1512

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.62%. Comparing base (b5bfd34) to head (6372fd3).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1511       +/-   ##
===========================================
+ Coverage   28.37%   78.62%   +50.25%     
===========================================
  Files         175      175               
  Lines       10957    10957               
  Branches       50     1021      +971     
===========================================
+ Hits         3109     8615     +5506     
+ Misses       7848     2338     -5510     
- Partials        0        4        +4     
Flag Coverage Δ
mutation 73.24% <ø> (?)
unit 28.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubiesonthesky
Copy link
Collaborator Author

I'm merging this to get the benefit for other fixes. But I'm up for fixing / improving the code in follow-ups.

@rubiesonthesky rubiesonthesky merged commit be900f9 into JoshuaKGoldberg:main Apr 1, 2024
14 of 15 checks passed
@rubiesonthesky rubiesonthesky deleted the fix-test-setup-tsconfig branch April 7, 2024 16:59
@JoshuaKGoldberg
Copy link
Owner

Thanks - I've been a little slammed this month, sorry for not responding quickly. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Codecov action isn't uploading coverage
2 participants