Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svdvals is wrong for nonsquare blocks #95

Closed
mzgubic opened this issue May 13, 2022 · 0 comments · Fixed by #96
Closed

svdvals is wrong for nonsquare blocks #95

mzgubic opened this issue May 13, 2022 · 0 comments · Fixed by #96
Labels
bug Something isn't working

Comments

@mzgubic
Copy link
Collaborator

mzgubic commented May 13, 2022

julia> b_nonsq = BlockDiagonal([rand(3, 4), rand(4, 3)]);

julia> svdvals(b_nonsq)
6-element Vector{Float64}:
 2.246378413353857
 1.7899313104769115
 0.8175846160990499
 0.4445749743334662
 0.2728361345688726
 0.08535212940246302

julia> svdvals(Matrix(b_nonsq))
7-element Vector{Float64}:
 2.246378413353856
 1.7899313104769117
 0.8175846160990496
 0.444574974333466
 0.27283613456887246
 0.08535212940246334
 0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant