[PkgEval] DataStructures may have a testing issue on Julia 0.4 (2014-10-23)

[IainNZ]

PackageEvaluator.jl is a script that runs nightly. It attempts to load all Julia packages and run their tests (if available) on both the stable version of Julia (0.3) and the nightly build of the unstable version (0.4). The results of this script are used to generate a package listing enhanced with testing results.

On Julia 0.4

• On 2014-10-22 the testing status was Tests pass.
• On 2014-10-23 the testing status changed to Package doesn't load.

Tests pass. means that PackageEvaluator found the tests for your package, executed them, and they all passed.

Package doesn't load. means that PackageEvaluator did not find tests for your package. Additionally, trying to load your package with using failed.

Special message from @IainNZ: This change may be due to JuliaLang/julia#8712.

This issue was filed because your testing status became worse. No additional issues will be filed if your package remains in this state, and no issue will be filed if it improves. If you'd like to opt-out of these status-change messages, reply to this message saying you'd like to and @IainNZ will add an exception. If you'd like to discuss PackageEvaluator.jl please file an issue at the repository. For example, your package may be untestable on the test machine due to a dependency - an exception can be added.

Test log:

>>> 'Pkg.add("DataStructures")' log
INFO: Installing DataStructures v0.3.4
INFO: Package database updated

>>> 'using DataStructures' log
ERROR: K not defined
 in include at ./boot.jl:242
 in include_from_node1 at ./loading.jl:128
 in include at ./boot.jl:242
 in include_from_node1 at ./loading.jl:128
 in reload_path at ./loading.jl:152
 in _require at ./loading.jl:67
 in require at ./loading.jl:52
 in require_3B_3948 at /home/idunning/julia04/usr/bin/../lib/julia/sys.so
 in include at ./boot.jl:242
 in include_from_node1 at loading.jl:128
 in process_options at ./client.jl:293
 in _start at ./client.jl:362
 in _start_3B_3776 at /home/idunning/julia04/usr/bin/../lib/julia/sys.so
while loading /home/idunning/pkgtest/.julia/v0.4/DataStructures/src/defaultdict.jl, in expression starting on line 17
while loading /home/idunning/pkgtest/.julia/v0.4/DataStructures/src/DataStructures.jl, in expression starting on line 46
while loading /home/idunning/pkgtest/.julia/v0.4/DataStructures/testusing.jl, in expression starting on line 2
Julia Version 0.4.0-dev+1249
Commit 23a9373 (2014-10-23 04:46 UTC)
Platform Info:
  System: Linux (x86_64-unknown-linux-gnu)
  CPU: Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Sandybridge)
  LAPACK: libopenblas
  LIBM: libopenlibm
  LLVM: libLLVM-3.3


>>> test log
no tests to run
>>> end of log

[garborg]

This was in fact caused by JuliaLang/julia#8712.

It's the second 'K' in the signature here:

immutable DefaultDictBase{K,V,F,D<:Associative{K,V}} <: Associative{K,V}
    default::F
    d::D
end

I thought this would work:

immutable DefaultDictBase{K,V,F,D<:Associative} <: Associative{K,V}
    default::F
    d::D{K,V}
end

but ERROR: type: instantiate_type: expected TypeConstructor, got Type{D<:Associative{K,V}}

[kmsquire]

What would work would be to remove the {K,V} from the type, but ensure the correct types are used during construction. (In fact, the {K,V} in the original version were for documentation anyway, since the element types were not enforced.)

[kmsquire]

(I wrote the original.)

[Keno]

This isn't particularly nice, but any reason not to just do:

    immutable DefaultDictBase{K,V,F,D} <: Associative{K,V}
        default::F
        d::D

        check_D(D,K,V) = (D <: Associative{K,V}) ||
            error("Default dict must be <: Associative{K,V}")

        DefaultDictBase(x::F, kv::AbstractArray{(K,V)}) = (check_D(D,K,V); new(x, D(kv)))
        DefaultDictBase(x::F, d::DefaultDictBase) = (check_D(D,K,V); DefaultDictBase(x, d.d))
        DefaultDictBase(x::F, d::D=D()) = (check_D(D,K,V); new(x, d))
        DefaultDictBase(x, ks, vs) = (check_D(D,K,V); new(x, D(ks,vs)))

    end