Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml: Add mac aarch64 CI, codecov v4 #1127

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Update ci.yml: Add mac aarch64 CI, codecov v4 #1127

merged 4 commits into from
Mar 8, 2024

Conversation

ViralBShah
Copy link
Contributor

@ViralBShah ViralBShah commented Feb 28, 2024

Add Mac aarch64 CI
Add codecov v4
Add a 20 min timeout
Run stable x86, LTS x64, and nightly x64 only on linux

@ViralBShah ViralBShah closed this Feb 28, 2024
@ViralBShah ViralBShah reopened this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (ba1f4d2) to head (db74663).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
+ Coverage   90.08%   90.12%   +0.04%     
==========================================
  Files           9        9              
  Lines        2309     2309              
==========================================
+ Hits         2080     2081       +1     
+ Misses        229      228       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor Author

We should merge this - but there seems to be an issue on precompilation with julia nightly.

@ViralBShah ViralBShah enabled auto-merge (squash) March 7, 2024 23:03
@ViralBShah ViralBShah requested a review from quinnj March 7, 2024 23:03
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ViralBShah!

@ViralBShah ViralBShah merged commit acd36a6 into main Mar 8, 2024
9 of 10 checks passed
@ViralBShah ViralBShah deleted the vs/ci branch March 8, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants